Open
Conversation
sbc100
force-pushed
the
wasm_bigint
branch
2 times, most recently
from
2484a29 to
b84c9bd
Compare
kripken
approved these changes
Oct 22, 2025
sbc100
force-pushed
the
wasm_bigint
branch
3 times, most recently
from
834c3bd to
aa256bb
Compare
Member
Author
|
Hm.. it looks like more work is requires to make the binaryen API bigint friendly. @kripken did you take a look at this in the past? |
Member
|
Hmm, no, I don't recall doing that. More generally, my hope is we can move binaryen.js to embind so stuff like this is handled automatically. |
Member
Author
It seems like there are places where the API uses 64-bit stuff and is not expecting it to simply use bigints |
sbc100
force-pushed
the
wasm_bigint
branch
3 times, most recently
from
2a689a6 to
991158b
Compare
This flag has been enabled by default in emscripten for a while now so I don't think we need this here anymore. The main user-visible effect of this change is that it makes the `module.i64.const` JS method now simply take a single bigint rather than a pair numbers.
Member
Author
|
I decided to look into the changes needed to the JS API.. WDYT? |
sbc100
changed the title
kripken
reviewed
Oct 24, 2025
Member
kripken
left a comment
kripken
left a comment
There was a problem hiding this comment.
Changes make sense to me, but they are breaking, so please update the changelog.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This flag has been enabled by default in emscripten for a while now so I don't think we need this here anymore.
Also remove the
-Wno-experimentalflag which is no longer needed for-sMEMORY64.Also remove
-sMODULARIZEwhich is implied by-sEXPORT_ES6.